Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout immediately after clicking "logout" #507

Open
MrMinos opened this issue Apr 28, 2019 · 2 comments
Open

Logout immediately after clicking "logout" #507

MrMinos opened this issue Apr 28, 2019 · 2 comments

Comments

@MrMinos
Copy link
Member

MrMinos commented Apr 28, 2019

Currently after clicking "Logout" under the dropdown menu on ocfweb, you need to click logout again on this following screen.

I am not sure if there is a reason why we have this scheme of things, but this seems like a bad user experience, especially most websites log you out immediately on a single click.

@jvperrin
Copy link
Member

This is to prevent accidentally clicking it and logging out of your whole session and losing whatever you were working on. Most websites are less state than a whole desktop login (which can include multiple website logins for instance). I'd agree it's not great because people are left accidentally logged in due to this, but I think if we made this single-click we'd have to make it harder to hit by accident at the same time.

@kpengboy
Copy link
Member

@jvperrin Minos is talking about the log out button on ocfweb, not on the desktop environment.

I believe the purpose of having a separate button was to provide some CSRF protection. But there are better ways to implement this; for example GitHub's logout link logs you out on clicking it, but if you try to navigate to the logout URL directly you get a page with a log out button you have to click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants