Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] conflicts with [email protected] #5

Open
rajivpoddar opened this issue Jun 19, 2024 · 2 comments
Open

[email protected] conflicts with [email protected] #5

rajivpoddar opened this issue Jun 19, 2024 · 2 comments

Comments

@rajivpoddar
Copy link

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/svelte
npm error   dev svelte@"^5.0.0-next.1" from the root project
npm error
npm error Could not resolve dependency:
npm error peer svelte@"^3.49.0 || ^4.0.0" from [email protected]
npm error node_modules/embla-carousel-svelte
npm error   embla-carousel-svelte@"^8.1.3" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/rajiv/.npm/_logs/2024-06-19T05_58_01_485Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/rajiv/.npm/_logs/2024-06-19T05_58_01_485Z-debug-0.log
@ocluf
Copy link
Owner

ocluf commented Jun 20, 2024

Hey rajiv,

Yes it seems the embla-carousel package doesn't officially support svelte 5 yet even though it seems to work fine. I normally use pnpm where you'll just get a warning.

You can either:

  • use npm with --force or --legacy-peer-deps
  • use pnpm (basically npm but way quicker)
  • remove the feature carousel component and the embla carousel dependency as that is the only place it gets used.

Will leave this issue open with that solution until official svelte 5 support drops for the package.

@davidjerleke
Copy link

davidjerleke commented Aug 3, 2024

@rajivpoddar, @ocluf, I’m accepting a PR to make embla-carousel compatible with Svelte v5 and up. Please see the following discussion for details:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants