Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update query\dlr.go for project structure #97

Open
Feyzanrs opened this issue Jul 13, 2024 · 0 comments
Open

Update query\dlr.go for project structure #97

Feyzanrs opened this issue Jul 13, 2024 · 0 comments
Assignees
@mervegonc
Labels
Be medium priority Important issues to be addressed soon waiting topic Issue is waiting for a topic label

Comments

@Feyzanrs
Copy link
Member

We need to make several changes to the content of the file located at op-be-graphql\internal\application\presentation\port\query\dlr.go to align it with the structure of our project.

Change Details

  • DlrQueryPort interface should be renamed to BookQueryPort.
  • GetDlrsByFilter method name should be changed to GetPagesByFilter.
  • Method parameters and return types should be updated from pb.DlrFilter and pb.Dlrs to pb.PageFilter and pb.Pages, respectively.

Additionally, rename the file to book.go

The changes will be merged into the refactor/team/89/dlr-switch-book first. Therefore, set the base branch of the pull request as refactor/team/89/dlr-switch-book
@octopos-prime octopos-prime added Be medium priority Important issues to be addressed soon waiting topic Issue is waiting for a topic label labels Jul 13, 2024
@mervegonc mervegonc mentioned this issue Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mervegonc mervegonc

Labels
Be medium priority Important issues to be addressed soon waiting topic Issue is waiting for a topic label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mervegonc @Feyzanrs @octopos-prime