Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend exceptions should not be sent to user #617

Closed
volodymyrss opened this issue Oct 26, 2023 · 9 comments · Fixed by #626
Closed

backend exceptions should not be sent to user #617

volodymyrss opened this issue Oct 26, 2023 · 9 comments · Fixed by #626
Assignees

Comments

@volodymyrss
Copy link
Member

OSError: [Errno 28] No space left on device: \'/scratch/oda-dda-interface-59df8cc467-vz8hf/ISGRILCSum/2023-10/25/09-11-03-219-68ba5dbb

@burnout87
Copy link
Collaborator

example:

image

@volodymyrss
Copy link
Member Author

yeah, this should be sent to the user. Only to sentry.

@burnout87 burnout87 linked a pull request Nov 6, 2023 that will close this issue
@burnout87
Copy link
Collaborator

This is partially related to an old issue about refactoring the exception (from backend) handling

@volodymyrss
Copy link
Member Author

Yes. But we should at least wrap something reasonable before showing.

@burnout87
Copy link
Collaborator

With #626 , now in the frontend we receive the following:

image

and on sentry, a more detailed message (along with the other exceptions):

image

@volodymyrss
Copy link
Member Author

With #626 , now in the frontend we receive the following:

Ok, but could you add something instructive, e.g. "Support team has been notified, we are working on the issue". Even better would be add something like "please click this check box if you want to be notified about resolving this issue" but it might be too complex before we migrate drupal.

@burnout87
Copy link
Collaborator

image

@volodymyrss
Copy link
Member Author

image

Thanks! Oh, another detail, looking on the screenshot, we could add "If you wish to provide further feedback, please use "Write Feedback" button below. We will make sure to respond to any feedback provided!"

@burnout87
Copy link
Collaborator

better:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants