Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a config to make an instrument public? #58

Closed
volodymyrss opened this issue Apr 11, 2024 · 5 comments · Fixed by #59 or #61
Closed

a config to make an instrument public? #58

volodymyrss opened this issue Apr 11, 2024 · 5 comments · Fixed by #59 or #61
Assignees

Comments

@volodymyrss
Copy link
Member

can we make at least a site-wide config (env variable?) to make an instrument public?

@dsavchenko dsavchenko linked a pull request Apr 11, 2024 that will close this issue
@volodymyrss
Copy link
Member Author

eh, so how do we actually make it public?

@volodymyrss volodymyrss reopened this Apr 17, 2024
@dsavchenko
Copy link
Member

This is a side-wide config for a moment, so that if you set default_creative_status = "production", every instrument deployed on this site will be public

There is a bug in the plugin when processing status change on-the-fly and corresponding fix oda-hub/dispatcher-plugin-nb2workflow#99 is waitin for review

@volodymyrss
Copy link
Member Author

This is a side-wide config for a moment, so that if you set default_creative_status = "production", every instrument deployed on this site will be public

That I get, but it also tries to read workflow_status from project and it's never there, right?

Would be best to real it from something, maybe like live-workflow-public topic for example (this would be easy I suppose)?

There is a bug in the plugin when processing status change on-the-fly and corresponding fix oda-hub/dispatcher-plugin-nb2workflow#99 is waitin for review

@dsavchenko
Copy link
Member

That I get, but it also tries to read workflow_status from project and it's never there, right?

Which place in code you are reffering to? It can't be there, project is a gitlab response.

Would be best to real it from something, maybe like live-workflow-public topic for example (this would be easy I suppose)?

Yes, this is very straightforward change. The solution is not ideal, but let's stick to it for now #61

@dsavchenko dsavchenko linked a pull request Apr 17, 2024 that will close this issue
@volodymyrss
Copy link
Member Author

That I get, but it also tries to read workflow_status from project and it's never there, right?

Which place in code you are reffering to?

there

roles = '' if project.get('workflow_status') == "production" else 'oda workflow developer',

It can't be there, project is a gitlab response.

it's mutable, it could have been assigned something

Would be best to real it from something, maybe like live-workflow-public topic for example (this would be easy I suppose)?

Yes, this is very straightforward change. The solution is not ideal, but let's stick to it for now #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants