Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Autoupdate functionality should clean up after itself. #240

Open
jgerigmeyer opened this issue Sep 3, 2024 · 0 comments
Open

[BUG] Autoupdate functionality should clean up after itself. #240

jgerigmeyer opened this issue Sep 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jgerigmeyer
Copy link
Member

The autoUpdate function used to update positioning when DOM elements move (or on scroll/resize) returns a cleanup function that should be called to remove observers.

It’s important that this function is only called/set-up when the floating element is open on the screen, and cleaned up when it’s removed. Otherwise, it can cause severe performance degradation, especially with many floating elements being created.

This is related to #91 (and partially implemented in #123).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant