Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenation of trace context for asynchronous requests in different goroutine #15

Open
CoderPoet opened this issue May 16, 2022 · 6 comments

Comments

@CoderPoet
Copy link

CoderPoet commented May 16, 2022

Feature request

This repo is the best idea I've seen recently !!!

Will consider supporting the scenario of starting a new goroutine for asynchronous client requests ?
In this scenario, is it impossible to connect the trace context through the goroutine context map ?

@CoderPoet CoderPoet changed the title Concatenation of trace context for asynchronous requests Concatenation of trace context for asynchronous requests in different goroutine May 16, 2022
@edeNFed
Copy link
Contributor

edeNFed commented May 17, 2022

Hi @CoderPoet happy to hear that you like this project! 😄
We are currently working on refactoring the goroutine tracking mechanism.
The new implementation will keep track of the goroutine creation tree instead of a single goroutine, which will solve this issue.

It should be finished in the next couple of weeks, stay tuned :)

@edeNFed
Copy link
Contributor

edeNFed commented Sep 29, 2022

Hi @CoderPoet.
Please try version v0.6.0. We changed the way we do context propagation and it no longer depends on goroutine ids, so passing context between different goroutines should work.

@CoderPoet
Copy link
Author

CoderPoet commented Feb 13, 2023

Hi @CoderPoet. Please try version v0.6.0. We changed the way we do context propagation and it no longer depends on goroutine ids, so passing context between different goroutines should work.

Whether the bpf_probe_write_user function is safe and whether it will have other side effects?

@CoderPoet
Copy link
Author

Hi @CoderPoet. Please try version v0.6.0. We changed the way we do context propagation and it no longer depends on goroutine ids, so passing context between different goroutines should work.

Whether the bpf_probe_write_user function is safe and whether it will have other side effects?

eg. In the go1.20 version, will there be problems with the memory GC of the header slice with Arenas?

@edeNFed
Copy link
Contributor

edeNFed commented Feb 15, 2023

Hi @CoderPoet
We allocate memory in an area that is not affected by the GC.
Recent changes like the addition of arenas should not have an effect on this.

@CoderPoet
Copy link
Author

CoderPoet commented Feb 20, 2023

@edeNFed Another problem is how to communicate the context in the process, adding it without integrating any otel SDK. For example, function A calls function B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants