Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OTEL SDK to parse exporter endpoint #21

Open
pavolloffay opened this issue Jul 12, 2022 · 0 comments
Open

Use OTEL SDK to parse exporter endpoint #21

pavolloffay opened this issue Jul 12, 2022 · 0 comments

Comments

@pavolloffay
Copy link
Contributor

Feature request

The exporter endpoint is not parsed directly in the code https://github.com/keyval-dev/opentelemetry-go-instrumentation/blob/master/pkg/opentelemetry/controller.go#L76 from which grpc connection is created.

This is not ideal because it limits how the exporter is initialized and it breaks semantics of OTEL_EXPORTER_OTLP_ENDPOINT which should have form of http(s)://host:port. See https://github.com/open-telemetry/opentelemetry-go/tree/main/exporters/otlp/otlptrace and OTEL spec.

I would propose to change the code to consume only env vars in OTEL defined format and leave parsing of the endpoint to OTEL SDK/exporter implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant