Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter types #6

Open
TTWNO opened this issue Mar 17, 2024 · 0 comments
Open

Stricter types #6

TTWNO opened this issue Mar 17, 2024 · 0 comments

Comments

@TTWNO
Copy link
Member

TTWNO commented Mar 17, 2024

  • Rate/Pitch/Volume should be an i8 between -100 and +100. Just create a wrapper type with a private internal.
  • Language, OutputModule, VoiceType should be produced only from using the Get* variant of the responses. This ensures that non-existant strings in the Set* variants will never be used.

There may be more, but I'm not sure. These are ones that can be confirmed from the SSIP documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant