Bump minimum requirements & supports SF 7.0 #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odolbeau
force-pushed
the
bump-dependencies
branch
6 times, most recently
from
e8af8be
to
85f6393
Compare
odolbeau
commented
Nov 29, 2023
| @@ -7,7 +7,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@master | |||
| - name: PHPStan | |||
| uses: docker://jakzal/phpqa:php8.0 | |||
| uses: docker://jakzal/phpqa:php8.2 | |||
There was a problem hiding this comment.
8.3 image is not ready yet but it should not be long. :)
jakzal/phpqa#417
odolbeau
force-pushed
the
bump-dependencies
branch
4 times, most recently
from
e6cd314
to
7f94bbd
Compare
odolbeau
force-pushed
the
bump-dependencies
branch
from
7f94bbd
to
303f96e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests failed for sf7.0 with dev dependencies (prophecy is probably not ready yet do deal with last debal verison? 🤔 ) and for php8.3, should I remove them or we can keep them for later?
IMO this PR should be merged after #154 & released in a new minor version.
Close #143