Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

Indent: none of it works as expected #95

Open
Zynton opened this issue Feb 6, 2020 · 2 comments
Open

Indent: none of it works as expected #95

Zynton opened this issue Feb 6, 2020 · 2 comments
Assignees

Comments

@Zynton
Copy link
Contributor

Zynton commented Feb 6, 2020

For some reason it indents/outdents only when selecting two blocks of texts separated by... a line break. Meaning <p>abc</p><p>def</p> will not indent.
Try indenting <p>abc<br>d[ef<br>g]hi</p> and you'll get <p> abc<br> def<br> ghi</p>
Try outdenting <p>a [b c<br>d e] f</p> and you'll get <p>abc<br>def</p>.

Well, when the range is collapsed, adding 4 spaces does work.

All tests pass because they are too limited. Is there a reason they don't seem to follow we3's tests?

@dmo-odoo
Copy link
Collaborator

dmo-odoo commented Feb 7, 2020

@Zinston If I'm not mistaken, the corresponding we3 tests are not in https://github.com/odoo-dev/jabberwock/blob/master/packages/core/test/todo.md ?

@Zynton
Copy link
Contributor Author

Zynton commented Jun 25, 2020

No, they should have been added when implementing indent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants