Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn about r- on forward port if all others are merged (/ not approved) #934

Open
xmo-odoo opened this issue Aug 23, 2024 · 0 comments
Open

Don't warn about r- on forward port if all others are merged (/ not approved) #934

xmo-odoo opened this issue Aug 23, 2024 · 0 comments
Labels
mergebot

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Aug 23, 2024 •
edited
Loading

odoo/odoo#177640 (comment) is completely unnecessary as as as of that moment all preceding forward ports were already merged:
image
xmo-odoo added a commit that referenced this issue Sep 6, 2024
@xmo-odoo
[FIX] *: unnecessary warning on r- of forward port
64f9dcb 
Reminding users that `r-` on a forward port only unreviews *that*
forwardport is useful, as `r+;r-` is not a no-op (all preceding
siblings are still reviewed).

However it is useless if all siblings are not approved or already
merged. So avoid sending the warning in that case.

Fixes #934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mergebot
Projects
Mergebot
Status: done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xmo-odoo