Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental / continuous staging #951

Open
xmo-odoo opened this issue Sep 16, 2024 · 0 comments
Open

Incremental / continuous staging #951

xmo-odoo opened this issue Sep 16, 2024 · 0 comments
Labels

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Sep 16, 2024

  • A staging 1 is created with PR A and PR B.
  • PR C is r+ later while the staging is running
    • A secondary staging 2is created with PR A, PR B and PR C
      • if staging 1 is green, the PR A and PR B are merged, PR C is merged right after if it's green
      • if staging 1 is red, everything is discarded

Dependencies

  • Support for co / multi-stagings per branch, like Stage concurrent splits #497 (or the idea of pre-staging splits before the CI has even failed, which I apparently didn't create a task for).

Considerations:

  • Thresholds / bounds? In theory this can mean 16 concurrent stagings per branch if there's a continuous stream of ready PRs with enough delay for their pickup.
  • If no thresholds, should batches still be batched or e.g. if 3 PRs are ready to we create a stack of 3 stagings? In that case we can remove splits entirely.
  • Synchronisation if later stagings are faster than earlier (on success we can merge the later stagings directly and cancel the previous two, on failure we need to wait to see which PR caused the failure).

Issues

  • Much lower resilience to non-deterministic failure e.g. if (1) passes and (2) fails we immediately consider (2) is broken, there's no rescue.
  • Possibility of odd behaviour in case of nondet failure e.g. if staging 4 succeeds but 3 fails it is a form of nondet, but we may already have failed (3)... then again if 4 succeeds before 3 fails we should have cancelled (1) - (3), just needs to be tested...
@d-fence d-fence added this to Mergebot Sep 16, 2024
@xmo-odoo xmo-odoo converted this from a draft issue Sep 16, 2024
@xmo-odoo xmo-odoo changed the title Incremental staging build. Incremental / continuous staging Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ideas
Development

No branches or pull requests

1 participant