Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing parameters via env vars or a config file #134

Open
fpriyatna opened this issue Apr 6, 2022 · 4 comments
Open

Enable passing parameters via env vars or a config file #134

fpriyatna opened this issue Apr 6, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request work in progress
Milestone

Comments

@fpriyatna
Copy link
Collaborator

Describe the bug
Right now, the tool has to be run in interactive mode thus making it difficult to automatize the whole process and integrate it with other systems

Expected behavior
It would be nice if the parameters needed by the tool can passed via either env vars or a config file.

@fpriyatna fpriyatna added the enhancement New feature or request label Apr 6, 2022
@daniel-dona daniel-dona self-assigned this Apr 6, 2022
@daniel-dona
Copy link
Collaborator

I think the best option can be a config file in YAML or JSON mapping the possible interactions with the existing interface. What do you think @dachafra?

@dachafra
Copy link
Member

and a config.ini similar to what we did for morph-kgc? It will be easier to integrate with the app as it is in python. If not, I'll be happy as well with a YAML file. @daniel-dona could yo do a draft of the file and post it here? Then we can implement it

@daniel-dona
Copy link
Collaborator

It can be a config.ini, at the end is the same, just a file with the same information the UI is asking the user:

  • List of sizes: 1, 5, ... (1 or more)
  • Distribution: JSON, XML, CSV, MongoDB, MySQL or CUSTOM (1 or more)
  • For CUSTOM distribution a value for every source (AGENCY, CALENDAR_DATES...) must be provided: JSON, XML, CSV, MongoDB, MySQL (select one)

I'll try to provide a complete example next week

@dachafra
Copy link
Member

ok, it makes sense. Let's wait for the final version of the file and then we will proceed and plan the implementation.
@daniel-dona if you think that JSON or YAML fit better than a config.ini file, go ahead ;-)

@dachafra dachafra added this to the v1.3 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress
Projects
None yet
Development

No branches or pull requests

3 participants