Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETH & XRP testnet addresses are being validated as valid mainnet addresses #46

Open
camslice opened this issue Nov 23, 2018 · 2 comments

Comments

@camslice
Copy link

When passing the 'prod' flag and attempting to validate against the mainnet for both ETH and XRP, the following testnet addresses are returned as valid:

ETH testnet addresses:
0xEf2C700943B7BD72Cae6C938188dD1aC9537b228
0xD1D1BAA591933BcA66F5e99be8843a0B7Df9f334

XRP testnet addresses:
r479Q1f3xm4VfAxNLoXAVKhSN1E8FArztD
rDHEEzqZ4EhqN1ij1w5xhbx55vwLjhQZgo

@liamaharon
Copy link

There is no difference between Etheruem mainnet and testnet addresses. You'll probably find the same thing for XRP addresses.

@camslice
Copy link
Author

camslice commented Apr 1, 2020

I did notice this. Could be good to add this to your documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@camslice @liamaharon and others