Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable SMS Providers #664

Open
vigneshhari opened this issue Jan 18, 2022 · 15 comments · May be fixed by #2697
Open

Configurable SMS Providers #664

vigneshhari opened this issue Jan 18, 2022 · 15 comments · May be fixed by #2697
Labels
good first issue Good for newcomers hacktoberfest P3 Low priority

Comments

@vigneshhari
Copy link
Member

vigneshhari commented Jan 18, 2022

Currently we only support SNS https://github.com/coronasafe/care/blob/develop/care/utils/sms/sendSMS.py#L7-L23
It would be good to have it configurable by the deployments

We could use https://github.com/roaldnefs/django-sms and write our own backends for other sms providers
note, this package will require us to make our own backend for sns as well

@vigneshhari
Copy link
Member Author

@gigincg and @mathew-alex to add more info

@dauntlessnomad dauntlessnomad added the P3 Low priority label Jan 19, 2022
@gigincg gigincg added this to Care Jan 26, 2022
@gigincg gigincg moved this to Wishlist in Care Jan 26, 2022
@sainak sainak added the good first issue Good for newcomers label Jun 6, 2023
@nikhilagastya
Copy link

@sainak can you explain this issue

@suhani221
Copy link

Hi,I would like to work on this issue.@gigincg and @mathew-alex could you please give more information on the same?

@sainak sainak changed the title Configurable SMS and Email Providers Configurable SMS Providers Mar 20, 2024
@sainak
Copy link
Member

sainak commented Mar 20, 2024

@suhani221, updated the issue body, have a look and ping if you want to work on it

@Gpro654321
Copy link

@sainak
I would like to contribute to this repo. But When I tried setting up the local development containers using docker (as per instructions here) ,
When I ran make up I got the following error,
docker compose -f docker-compose.yaml -f 'docker-compose.local.yaml' up -d --wait unknown shorthand flag: 'f' in -f See 'docker --help'.
I had used docker-compose, django in my pet projects.
I am a complete begineer to open source. Could you please help me get the containers up and running..?

@sainak
Copy link
Member

sainak commented Mar 20, 2024

@Gpro654321 you could be using an outdated version of docker, try to update it or run docker-compose -f 'docker-compose.yaml' -f 'docker-compose.local.yaml' up -d --wait

@Gpro654321
Copy link

@sainak
Thanks, got the containers running.

After a bit of reading, I sort of understand the issue and have even worked out what needs to be implemented. But I have the following roadblocks in my way, I request you to help me clear them..

1. No links seen in homepage for me to navigate the site
But when i navigate to http://localhost:9000, I see a page as in the attachment below
care_homepage
, like I do not see any links anywhere for me to navigate

2. username password combo provided in the documentation not working
Also I navigated to http://localhost:9000/admin tried using the [username:password] combo of [devdistrictadmin:Coronasafe@123], but thats not working, I tried searching it here too but didn't help.

@AnkurPrabhu
Copy link
Contributor

hey @sainak can i work on this ? also i need a little more info and context i was not able to find the updated issue body

@AnkurPrabhu
Copy link
Contributor

After a bit of reading, I sort of understand the issue and have even worked out what needs to be implemented. But I have the following roadblocks in my way, I request you to help me clear them..

Hey ping me on slack i am in the ohc slack group we can get your local setup done

@sainak
Copy link
Member

sainak commented Mar 25, 2024

hey @sainak can i work on this ? also i need a little more info and context i was not able to find the updated issue body

what info are you looking for?

@AnkurPrabhu
Copy link
Contributor

@sainak i want to know what is the expected output here

@AnkurPrabhu
Copy link
Contributor

can you also assign it to me

@sainak
Copy link
Member

sainak commented Mar 25, 2024

@AnkurPrabhu the expected outcome is to give users multiple choices of sms service providers

@AnkurPrabhu
Copy link
Contributor

AnkurPrabhu commented Mar 26, 2024

@sainak i have made the custom backend for sns, you want me to add tests as well and replace sendSMS with the django-sm send_sms ?

@himanshu-sharmav
Copy link

Hi @sainak , can I work on this issue if its not resolved?

@DraKen0009 DraKen0009 linked a pull request Jan 2, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest P3 Low priority
Projects
Status: Wishlist
9 participants