Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache-control header for index.html #8516

Closed
sainak opened this issue Sep 10, 2024 · 6 comments · Fixed by #8575
Closed

Add cache-control header for index.html #8516

sainak opened this issue Sep 10, 2024 · 6 comments · Fixed by #8575
Assignees
@sainak @vishwansh01
Labels
good first issue Good for newcomers

Comments

@sainak
Copy link
Member

sainak commented Sep 10, 2024 •
edited
Loading

In the nginx conf there are no cache control headers added which causes the index.html to be cached by the browser

to fix this add a cache-control header with ttl = 7 days for regular files and ttl = 6 hrs for index.html
@sainak sainak added the good first issue Good for newcomers label Sep 10, 2024
@AdityaJ2305
Copy link
Contributor

Hi @sainak I would like to work on this feature. Could you assign it to me ?

@AdityaJ2305
Copy link
Contributor

Work In Progress

@AdityaJ2305
Copy link
Contributor

@sainak I see the backend sets Cache-Control: max-age=31536000, immutable. Should I use proxy_hide_header to change this, or is it intentional?
Screenshot 2024-09-12 at 12 16 37 PM

@AdityaJ2305
Copy link
Contributor

@sainak Should I make the PR with proxy_hide_header ?

@vishwansh01 vishwansh01 mentioned this issue Sep 19, 2024
Merged
@vishwansh01
Copy link
Contributor

Hi @sainak !
I just created a pull request solving this issue : #8575

@AdityaJ2305
Copy link
Contributor

Hi @sainak @rithviknishad ,
I was working on this issue and had a few questions, but noticed @vishwansh01 submitted a PR without being assigned. Could you clarify how to proceed in such cases?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainak sainak

@vishwansh01 vishwansh01

Labels
good first issue Good for newcomers
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding cache control headers vishwansh01/care_fe
3 participants
@sainak @AdityaJ2305 @vishwansh01