Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCE Support #208

Open
ohmoreno opened this issue Aug 18, 2020 · 12 comments · May be fixed by #421
Open

PKCE Support #208

ohmoreno opened this issue Aug 18, 2020 · 12 comments · May be fixed by #421
Assignees
Labels
enhancement Issues & PRs related to new features.
Milestone

Comments

@ohmoreno
Copy link

Hello,

Do you have plans to implement PKCE support?

@timnolte
Copy link
Collaborator

@ohmoreno at the moment there is not a clear road map for future enhancements. We'll add this as a future enhancement to consider.

@timnolte timnolte added the enhancement Issues & PRs related to new features. label Aug 20, 2020
@ohmoreno
Copy link
Author

OK, I'll be looking forward to it.

I'll give it a good read so maybe I can be of help.

Thanks.

@timnolte
Copy link
Collaborator

Adding here for reference: https://tools.ietf.org/html/rfc7636

@joch0a
Copy link

joch0a commented Sep 24, 2020

It would be really nice to have the PKCE support in order to be more secure

@christianostrem
Copy link

christianostrem commented May 20, 2021

From 2022 PKCE ,state og nonce will be a requirement on some services. Its a recommendation from IETF.org

The Internet Engineering Task Force (IETF) is an open standards organization, which develops and promotes voluntary Internet standards, in particular the standards that comprise the Internet protocol suite (TCP/IP).[3] It has no formal membership roster or membership requirements. All participants and managers are volunteers, though their work is usually funded by their employers or sponsors.

https://no.wikipedia.org/wiki/Internet_Engineering_Task_Force

@Rahe
Copy link

Rahe commented Apr 12, 2022

Hello,

We've developped an addon for the plugin to add support of PKCE https://github.com/BeAPI/openid-connect-generic-pkce-addon/.

Maybe it can help some people :)

Nicolas,

@ohmoreno
Copy link
Author

Sweet!
I'll check it out.
Thanks man.

@timnolte
Copy link
Collaborator

@Rahe would you want to open up a PR to add this feature. We'd be very happy to include this as a built-in feature in the next release.

@petitphp
Copy link

petitphp commented Jul 8, 2022

@timnolte We can work on a PR to add the feature.

Should PKCE be active by default or should it be controlled by a new option ?

@timnolte
Copy link
Collaborator

timnolte commented Jul 8, 2022

In general all new features should be off by default, unless their on state is such that it wouldn't interfere with existing installations.

@petitphp petitphp linked a pull request Jul 11, 2022 that will close this issue
6 tasks
@vvdevteam
Copy link

@timnolte any update on this? any way I can help?

@timnolte timnolte added this to the 3.10.0 milestone May 11, 2023
@timnolte timnolte self-assigned this May 11, 2023
@timnolte timnolte modified the milestones: 3.10.0, 4.0.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues & PRs related to new features.
Projects
Development

Successfully merging a pull request may close this issue.

7 participants