Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: ScrollbarWrapper is accessing getDOMNode or findDOMNode inside its render(). #28

Open
paulle81 opened this issue Aug 13, 2015 · 1 comment

Comments

@paulle81
Copy link

Hi there,

Getting the following warning when mounting the component.

Warning: ScrollbarWrapper is accessing getDOMNode or findDOMNode inside its render(). render() should be a pure function of props and state. It should never access something that requires stale data from the previous render, such as refs. Move this logic to componentDidMount and componentDidUpdate instead.

Seems to be mixins/scrollbar.jsx accessing getDOMNode then directly calling into render causing the problem. Any plans on improving this?

@ojame
Copy link
Owner

ojame commented Aug 14, 2015

Looks like it's somewhere further up the chain (just a method from the mixin).

There's a few things I need to do with this library including re-writing it so it's not a mixin (use ES6 classes) and to have a better API.

So yep, definitely plans on improving this :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants