Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubly-escaped YouTube links (and possibly others) #153

Open
corrideat opened this issue Sep 14, 2024 · 0 comments
Open

Doubly-escaped YouTube links (and possibly others) #153

corrideat opened this issue Sep 14, 2024 · 0 comments

Comments

@corrideat
Copy link
Member

Problem

On https://groupincome.org/faq/ the links to YouTube links are wrong (although not completely broken) as the URL params are double escaped (the links use & instead of &, i.e., the markup is & instead of either of & or &).

Another issue: those links have target="_blank" but lack rel="noopener". Although in recent browsers this is fine because target="_blank" implies the latter, in older browsers that's not the case. I still prefer including it, but it's not strictly required.

Solution

Identify and fix the issue leading to the string being escaped twice. This may affect other links too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant