Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat request]: optimize site load time #24

Open
okjintao opened this issue Aug 2, 2021 · 5 comments
Open

[feat request]: optimize site load time #24

okjintao opened this issue Aug 2, 2021 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@okjintao
Copy link
Owner

okjintao commented Aug 2, 2021

  • precompute json for default + custom scoring
  • load wizard info only, pull scores + rankings from pre computed static data
@okjintao okjintao added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 2, 2021
@aranair
Copy link

aranair commented Aug 9, 2021

one-off? or like ...refactor everything out into a set of script to generate?
simple one like this? -> https://github.com/axejintao/wizards-viewer/compare/main...aranair:aranair.static-ranking?expand=1

@aranair
Copy link

aranair commented Aug 9, 2021

lol, if weighting needs to be done, then static ranks are also no longer possible

@okjintao
Copy link
Owner Author

okjintao commented Aug 9, 2021

@aranair
i think we could still use static if there is a few weight options vs. a fully custom weighting system.
did you find that your change sped up the site - i'm looking at the diff now

@aranair
Copy link

aranair commented Aug 9, 2021

hmm true, if its discrete sets.


I think it didn't help that much (imo) - The search and toggling between ranks still feels kinda sluggish

@aranair
Copy link

aranair commented Aug 9, 2021

oddly, it's actually pretty fast to filter by something like head: xxx but just querying by id feels alot slower

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants