Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio fragment broken with hugo versions later than 0.80.0 #880

Open
mrhappyma opened this issue Sep 14, 2022 · 8 comments
Open

Portfolio fragment broken with hugo versions later than 0.80.0 #880

mrhappyma opened this issue Sep 14, 2022 · 8 comments
Labels
deps_hugo hugo dependency compatability issues

Comments

@mrhappyma
Copy link
Contributor

mrhappyma commented Sep 14, 2022

Hello!

I have a bit of an interesting scenario I was unable to figure out. I was making a site using the syna theme and added a portfolio fragment. I committed the changes to a new branch, and had Netlify make a preview:
https://6320e78fce2f740008728766--lt-monsters.netlify.app/
So far so good, everything was working. I merged it into the main branch, no other changes:
https://6320e7f5ba71700008b9d0df--lt-monsters.netlify.app/
The pop-ups don't work anymore. I can't think of anything that would make a difference.

@mrhappyma
Copy link
Contributor Author

ha - found the problem just after creating an issue about it

I had upgraded the hugo version in netlify.toml, but only for production environments. This fragment seems to break with more recent versions.

@mrhappyma mrhappyma changed the title Portfolio pop-ups not working Portfolio fragment broken with newer hugo versions Sep 14, 2022
@mrhappyma
Copy link
Contributor Author

mrhappyma commented Sep 14, 2022

Seems like 0.80.0 is the highest version that this works with
mrhappyma/lt#3

@mrhappyma mrhappyma changed the title Portfolio fragment broken with newer hugo versions Portfolio fragment broken with hugo versions later than 0.80.0 Sep 14, 2022
@stp-ip
Copy link
Member

stp-ip commented Sep 17, 2022

Disable minification as this is the thing that seems to break since a specific hugo version. Dup #865

@stp-ip stp-ip added the deps_hugo hugo dependency compatability issues label Sep 17, 2022
@gromain
Copy link

gromain commented Sep 29, 2022

Just for information, this is still broken with Hugo v102.3 extended and with:

[minify]
disableJS = true

@stp-ip
Copy link
Member

stp-ip commented Oct 1, 2022

Even with minification disabled this is the case? Thank you for clarifying.

@gromain
Copy link

gromain commented Oct 3, 2022

Items fragment is also broken, issue is the same as with portfolio.

Looks like the issue stems from https://github.com/okkur/syna/blob/master/layouts/partials/helpers/subitems.html

@gromain
Copy link

gromain commented Oct 3, 2022

Could be an issue similar to what was solved by @abrain in #869.

@stp-ip
Copy link
Member

stp-ip commented Oct 3, 2022

Thanks for the pointers. Happy for any PRs, but will see, that I get finally some time to put more time back into Syna in the comings months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps_hugo hugo dependency compatability issues
Development

No branches or pull requests

3 participants