From 58bc4eac6632035dd87f4bbbdba1ee5623ecaf96 Mon Sep 17 00:00:00 2001 From: Reinoud Kruithof <2184455+reinoudk@users.noreply.github.com> Date: Tue, 20 Aug 2024 12:52:34 +0200 Subject: [PATCH 1/2] Update test assertion for inactivity_period default It checks that `inactivity_period` is not set if not defined, which is the desired behavior. --- okta/resource_okta_app_signon_policy_rule_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/okta/resource_okta_app_signon_policy_rule_test.go b/okta/resource_okta_app_signon_policy_rule_test.go index d0a438287..92b5a0f56 100644 --- a/okta/resource_okta_app_signon_policy_rule_test.go +++ b/okta/resource_okta_app_signon_policy_rule_test.go @@ -46,7 +46,7 @@ func TestAccResourceOktaAppSignOnPolicyRule(t *testing.T) { resource.TestCheckResourceAttr(resourceName, "network_connection", "ANYWHERE"), resource.TestCheckResourceAttr(resourceName, "constraints.#", "0"), resource.TestCheckResourceAttr(resourceName, "re_authentication_frequency", "PT2H"), - resource.TestCheckResourceAttr(resourceName, "inactivity_period", "PT1H"), + resource.TestCheckNoResourceAttr(resourceName, "inactivity_period"), resource.TestCheckResourceAttr(resourceName, "risk_score", "LOW"), ), }, From ff186b7cb7ce5746f841a85fbe63b83b66298ab4 Mon Sep 17 00:00:00 2001 From: Reinoud Kruithof <2184455+reinoudk@users.noreply.github.com> Date: Tue, 20 Aug 2024 12:53:39 +0200 Subject: [PATCH 2/2] Remove default value for inactivity_period --- okta/resource_okta_app_signon_policy_rule.go | 1 - 1 file changed, 1 deletion(-) diff --git a/okta/resource_okta_app_signon_policy_rule.go b/okta/resource_okta_app_signon_policy_rule.go index cf052a8c3..751646b41 100644 --- a/okta/resource_okta_app_signon_policy_rule.go +++ b/okta/resource_okta_app_signon_policy_rule.go @@ -180,7 +180,6 @@ The only difference is that these fields are immutable and can not be managed: ' Type: schema.TypeString, Optional: true, Description: "The inactivity duration after which the end user must re-authenticate. Use the ISO 8601 Period format for recurring time intervals.", - Default: "PT1H", }, "constraints": { Type: schema.TypeList,