Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hardcoding the title and the description? #2

Open
inputsh opened this issue Jun 25, 2015 · 3 comments
Open

Stop hardcoding the title and the description? #2

inputsh opened this issue Jun 25, 2015 · 3 comments

Comments

@inputsh
Copy link
Contributor

inputsh commented Jun 25, 2015

Would it be useful to create a pull request that uses {{ site.title }} and {{ site.description }} from _config directory to stop them from being hardcoded into _layouts files?

I think that the title is very needed, but taking the description could be a bit too much because there won't be an option to use HTML code on the sidebar in the description.

@mneumegen
Copy link
Contributor

Hey @Aleksandar-Todorovic, that's a nice idea. The title/description probably should be set in the front matter rather than _config.yml because it shouldn't be the same on every page.

A pull request with that would be very useful :)

@inputsh
Copy link
Contributor Author

inputsh commented Jun 27, 2015

I already implemented the title fix, but I am having some troubles with understanding what to do with the description.

This theme uses a pretty big sidebar and I do think that the description in the sidebar should stay fixed no matter what page you're on. In my opinion, it just needs to be implemented from _config.yml instead of coded directly in the HTML code, but this will kind of reduce its customizability since users would not be able to implement HTML codes (like links and <strong> tags). After all, it's probably the best to leave site.description in clear text because of the web crawlers.

@mneumegen
Copy link
Contributor

Ahh I see what you mean. I thought you were talking about the meta description. Yes! that makes sense to have it in _config.yml send the PR through 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants