Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB (pure red and green) arrow colors do not have the best contrast #822

Open
nekohayo opened this issue Jan 24, 2022 · 3 comments · May be fixed by #955
Open

RGB (pure red and green) arrow colors do not have the best contrast #822

nekohayo opened this issue Jan 24, 2022 · 3 comments · May be fixed by #955
Labels
enhancement Indicates new feature requests good first issue Indicates a good issue for first-time contributors

Comments

@nekohayo
Copy link

This is a minor issue, but also fairly easy to fix. It seems like the red and green colors are juste the pure RGB values, and this makes them unpleasant to look at depending on which theme (light vs dark) you are using. Pure red is hard to see on a dark background, and pure green is hard to see on a white background.

It would probably be better to use the Tango color palette and use two sets of colors, for dark vs light background theme. Here are some ideas (just guessing which colors could be suitable, you'll have to try them out):

  • "Red" arrow: dark red (#a40000) for light theme and orange (#f57900, or #fcaf3e?) for dark theme
  • "Green" arrow: #4e9a06 for use in the light theme, and #8ae234 for dark theme
@oliexdev oliexdev added enhancement Indicates new feature requests good first issue Indicates a good issue for first-time contributors labels Apr 15, 2022
@oliexdev
Copy link
Owner

If somebody is willing to send a PR I would be happy.

@alt-shreya
Copy link

Has this been resolved? If not, I'd like to work on this.

@oliexdev
Copy link
Owner

no go ahead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests good first issue Indicates a good issue for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants