Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: open in sidebar #129

Open
marczellm opened this issue Aug 14, 2018 · 6 comments
Open

Feature request: open in sidebar #129

marczellm opened this issue Aug 14, 2018 · 6 comments

Comments

@marczellm
Copy link
Contributor

As a user, I would like to see the list of Feedly articles in a Firefox sidebar and open the full articles (on their website) in new tabs from there. (My current flow is: split the screen, snap FF to the right and a separate feedreader app to the left.)

Would this be possible? I can work on the implementation too and then pull request.

@olsh
Copy link
Owner

olsh commented Aug 14, 2018

Hi @marczellm,

Sounds like a great idea, I would very appreciate if you submit a PR.
Are you talking about the API?

@marczellm
Copy link
Contributor Author

marczellm commented Aug 14, 2018 via email

@olsh
Copy link
Owner

olsh commented Aug 14, 2018

It seems like the API is not supported in Chrome, so we should use preprocessing like this

@marczellm
Copy link
Contributor Author

I started a fork: https://github.com/marczellm/Feedly-Notifier/tree/feature/firefox-sidebar
Most things seems to work smoothly because popup UI and sidebar UI is equivalent in how it works in Firefox.

The main issue is that while popup width is set by the extension, sidebar width is user resizable. Opening the summary of an article makes the UI wider than the max possible sidebar width. For sidebar, the UI should be made width-responsive. Unfortunately I have very little experience with CSS.

@olsh
Copy link
Owner

olsh commented Aug 14, 2018

Thanks, I can try to help with this when I have some time, but probably this won't happen soon.

@marczellm
Copy link
Contributor Author

Quoting https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups:

If the user moves the extension's button to the menu or it appears in the toolbar overflow, then the popup appears inside the menu's panel and is given a fixed width.

This means it looks like this:

image

There is no way to scroll to the right hand side buttons.

Don't you think that it would be better if the entire UI would resize instead of having a fixed width? I tested and it would only require removing explicitly set widths in popup.js. Would that cause problems in other browsers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants