suConn fails with _BlitzGateway object has no attribute '_ctx'

[glyg]

Hi ome team,

I have an error when trying to use suConn

...
File "/opt/omero/server/impomero-main/impomero/annotation_job.py", line 60, in auto_annotate
user_conn = conn.suConn(user)
File "/opt/omero/server/venv3/lib64/python3.6/site-packages/omero/gateway/__init__.py", line 1853, in suConn
if self.isAdmin():
File "/opt/omero/server/venv3/lib64/python3.6/site-packages/omero/gateway/__init__.py", line 2435, in isAdmin
return self.getEventContext().isAdmin
File "/opt/omero/server/venv3/lib64/python3.6/site-packages/omero/gateway/__init__.py", line 2322, in getEventContext
if self._ctx is None:
AttributeError: '_BlitzGateway' object has no attribute '_ctx'

This occurs if the BlitzGateway was not connected before suConn is called, as the _ctx attribute is not created. Maybe a more explicit connection error could be raised in this case?

[glyg]

of course I'm happy to open a PR for that if needed.

[will-moore]

Thanks for reporting.
It would certainly be nicer to have an explicit connection error here.
But I realise that the same is true of almost all the methods on the BlitzGateway - You'll get some error if you try to call them before you're connected, but it's not handled uniformly anywhere.

I guess we could create an @assert_connected decorator for all the methods we want to handle this, but that's probably a bigger job than you're looking for!?

[glyg]

I guess we could create an @assert_connected decorator for all the methods we want to handle this, but that's probably a bigger job than you're looking for!?

😄 I can surely write the decorator, and apply it to getEventContext, but I would let you judge where else to apply it!