Redefine timing_t as std::chrono::milliseconds
#1549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I understand, this change might affect the public API of dynamic selection, namely, the reporting requirements of the auto-tune policy. I suggest to take it for discussion, but not apply right now. |
SergeyKopienko
force-pushed
the
dev/skopienko/auto_tune_sycl_profiling_simplify_submit_and_change_timing_t_type
branch
3 times, most recently
from
5ca7d80 to
9c37557
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/auto_tune_sycl_profiling_simplify_submit_and_change_timing_t_type
branch
3 times, most recently
from
1a3b420 to
8d26128
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/auto_tune_sycl_profiling_simplify_submit_and_change_timing_t_type
branch
from
8d26128 to
1deb00d
Compare
|
@AnuyaWelling2801, what do you think, will you apply this PR or I may close it? |
Signed-off-by: Sergey Kopienko <[email protected]>
SergeyKopienko
force-pushed
the
dev/skopienko/auto_tune_sycl_profiling_simplify_submit_and_change_timing_t_type
branch
from
1deb00d to
6b84356
Compare
SergeyKopienko
deleted the
dev/skopienko/auto_tune_sycl_profiling_simplify_submit_and_change_timing_t_type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we redefine
timing_tasstd::chrono::millisecondsand removecount()function call at all, so we always operates by value with physical sense.Of course it's not mandatory improvement, we are able to apply it later.
@AnuyaWelling2801, up to you.