Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding information on how to use oneDPL on other vendor platforms #1951

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

timmiesmith
Copy link
Contributor

The PR adds notes to the Getting Started Guide on installing the oneAPI for NVIDIA GPUs plugin as well as a reference to the System Requirements section of the Developer's guide for the installation requirements to run oneDPL on CPU. This is meant to provide the documentation requested in uxlfoundation/open-source-working-group#51 on how to use oneDPL on different vendor hardware platforms.

@timmiesmith timmiesmith requested a review from mmichel11 December 2, 2024 20:09
@mmichel11
Copy link
Contributor

mmichel11 commented Dec 2, 2024

The uxlfoundation issue this is addressing requests, "... and also how to build from source for different processor targets".

Should we add a link to https://intel.github.io/llvm/GetStartedGuide.html#build-dpc-toolchain which contains instructions on how to build the CUDA / HIP DPC++ toolchain from source?

@timmiesmith
Copy link
Contributor Author

The uxlfoundation issue this is addressing requests, "... and also how to build from source for different processor targets".

Should we add a link to https://intel.github.io/llvm/GetStartedGuide.html#build-dpc-toolchain which contains instructions on how to build the CUDA / HIP DPC++ toolchain from source?

That I don't think we need to include. oneDPL with the OpenMP and/or oneTBB backends compile with multiple compilers so the DPC++ compiler isn't necessarily required, and I think since we've got information on CMake and the oneTBB and OpenMP requirements in the file we have the information needed to cover processor targets.

Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmiesmith timmiesmith merged commit c083b4c into main Dec 5, 2024
2 checks passed
@timmiesmith timmiesmith deleted the add-nv-plugin-instructions branch December 5, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants