Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNG] Shortening some test file names to avoid warnings on Windows #1960

Closed
wants to merge 2 commits into from
Closed

[RNG] Shortening some test file names to avoid warnings on Windows #1960

wants to merge 2 commits into from

Conversation

egrabovskaya
Copy link
Contributor

No description provided.

@egrabovskaya egrabovskaya changed the title [RNG] Shortening some test file names to avoid warning on Windows [RNG] Shortening some test file names to avoid warnings on Windows Dec 9, 2024
@egrabovskaya egrabovskaya requested a review from aelizaro December 9, 2024 09:39
aelizaro
aelizaro reviewed Dec 9, 2024
View reviewed changes
test/xpu_api/random/statistics_tests/extreme_value_distribution_dp_portion_test.pass.cpp
@@ -0,0 +1,183 @@
// -*- C++ -*-
//===-- extreme_value_distribution_dp_tests_set_portion_test.cpp ---------------------------------===//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check that new filenames are matched with the comments.
Also, a suggestion: maybe we can shorted distribution to distr as well, as it still seems very long

@akukanov
Copy link
Contributor

akukanov commented Dec 9, 2024 •
edited
Loading

The name of the PR suggests that existing tests are going to be changed, but the patch adds a bunch of new tests without deleting/renaming any old ones. Is that on purpose?

Generally, it would be better to have a short description of what the patch is supposed to do and why.

@egrabovskaya
Copy link
Contributor Author

The name of the PR suggests that existing tests are going to be changed, but the patch adds a bunch of new tests without deleting/renaming any old ones. Is that on purpose?

Generally, it would be better to have a short description of what the patch is supposed to do and why.

I am closing this PR to rename files in the proper way

@egrabovskaya egrabovskaya deleted the dev/egrabovs/shortening_test_file_names branch December 9, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelizaro aelizaro aelizaro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egrabovskaya @akukanov @aelizaro