Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBB_BUILD_APPLE_FRAMEWORKS missing headers #1512

Open
wtholliday opened this issue Sep 12, 2024 · 4 comments
Open

TBB_BUILD_APPLE_FRAMEWORKS missing headers #1512

wtholliday opened this issue Sep 12, 2024 · 4 comments
Labels

Comments

@wtholliday
Copy link

The frameworks generated by TBB_BUILD_APPLE_FRAMEWORKS have no headers. Is there a way to enable copying them? Does something need to be updated in CMakeLists.txt?

image

thanks!

@wtholliday
Copy link
Author

There's this:

if(TBB_BUILD_APPLE_FRAMEWORKS)
    set_target_properties(tbb PROPERTIES
        FRAMEWORK TRUE
        FRAMEWORK_VERSION ${TBB_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
        XCODE_ATTRIBUTE_PRODUCT_BUNDLE_IDENTIFIER com.intel.tbb
        MACOSX_FRAMEWORK_IDENTIFIER com.intel.tbb
        MACOSX_FRAMEWORK_BUNDLE_VERSION ${TBB_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
        MACOSX_FRAMEWORK_SHORT_VERSION_STRING ${TBB_BINARY_VERSION})
endif()

Probably should also have a value for PUBLIC_HEADER

@wtholliday
Copy link
Author

@wtholliday
Copy link
Author

I tried adding PUBLIC_HEADER "../include/oneapi/tbb.h" but CMake doesn't stick the file in the framework, and also doesn't even print a warning.

@wtholliday
Copy link
Author

wtholliday commented Sep 13, 2024

Someone suggested that the headers should be added using add_library as well, as in the FRAMEWORK docs example. Doesn't seem like they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant