You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The libghr crate currently contains numerous types used on the backend to forward to the frontend.
However, it makes no sense to compile all those info-gathering crates for the server side of things.
We should split out this functionality into another crate, or maybe just a feature flag. I generally prefer using a crate, as this limits the complexity of our Cargo features, but this would likely violate the orphan rule. (can't impl for external types)
This also duplicates the serde/syn builds, which may require different features, and thus, double the build times! Still, this may be worth it.
The text was updated successfully, but these errors were encountered:
onkoe
changed the title
Feature gate ghr crate's info gathering functionality
Feature gate libghr crate's info gathering functionality
Oct 19, 2024
this is still true with shared. preferable to have a feature here.
note that libghr/examples currently takes the vast majority of the cargo check time, as reqwest is pretty big. consider removing the pastebin example or making it's features optional. (but that second part's not really possible rn)
The
libghr
crate currently contains numerous types used on the backend to forward to the frontend.However, it makes no sense to compile all those info-gathering crates for the server side of things.
We should split out this functionality into another crate, or maybe just a feature flag. I generally prefer using a crate, as this limits the complexity of our Cargo features, but this would likely violate the orphan rule. (can't
impl
for external types)This also duplicates the
serde
/syn
builds, which may require different features, and thus, double the build times! Still, this may be worth it.The text was updated successfully, but these errors were encountered: