Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gate libghr crate's info gathering functionality #3

Open
onkoe opened this issue Oct 19, 2024 · 1 comment
Open

Feature gate libghr crate's info gathering functionality #3

onkoe opened this issue Oct 19, 2024 · 1 comment

Comments

@onkoe
Copy link
Owner

onkoe commented Oct 19, 2024

The libghr crate currently contains numerous types used on the backend to forward to the frontend.

However, it makes no sense to compile all those info-gathering crates for the server side of things.

We should split out this functionality into another crate, or maybe just a feature flag. I generally prefer using a crate, as this limits the complexity of our Cargo features, but this would likely violate the orphan rule. (can't impl for external types)

This also duplicates the serde/syn builds, which may require different features, and thus, double the build times! Still, this may be worth it.

@onkoe onkoe changed the title Feature gate ghr crate's info gathering functionality Feature gate libghr crate's info gathering functionality Oct 19, 2024
@onkoe
Copy link
Owner Author

onkoe commented Oct 27, 2024

this is still true with shared. preferable to have a feature here.

note that libghr/examples currently takes the vast majority of the cargo check time, as reqwest is pretty big. consider removing the pastebin example or making it's features optional. (but that second part's not really possible rn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant