From ce84bc243441f65f34a8a45d6c3021805b2e3d58 Mon Sep 17 00:00:00 2001 From: Jeremy Fowers Date: Fri, 1 Dec 2023 11:32:57 -0500 Subject: [PATCH] Fix/remove issue references Signed-off-by: Jeremy Fowers --- models/torchvision/skip/ssdlite320_mobilenet_v3_large.py | 2 +- src/turnkeyml/analyze/util.py | 2 +- src/turnkeyml/cli/cli.py | 3 --- src/turnkeyml/common/labels.py | 3 --- test/cli.py | 4 ---- 5 files changed, 2 insertions(+), 12 deletions(-) diff --git a/models/torchvision/skip/ssdlite320_mobilenet_v3_large.py b/models/torchvision/skip/ssdlite320_mobilenet_v3_large.py index 7cb539a..f551a8f 100644 --- a/models/torchvision/skip/ssdlite320_mobilenet_v3_large.py +++ b/models/torchvision/skip/ssdlite320_mobilenet_v3_large.py @@ -6,7 +6,7 @@ # Skip reason: triggers a bug in analysis where two models are discovered during # profiling instead of one. -# Reinstate this model once https://github.com/onnx/turnkeyml/issues/239 is fixed +# Reinstate this model once https://github.com/onnx/turnkeyml/issues/22 is fixed # Models discovered during profiling: diff --git a/src/turnkeyml/analyze/util.py b/src/turnkeyml/analyze/util.py index d5dc7c6..27e9659 100644 --- a/src/turnkeyml/analyze/util.py +++ b/src/turnkeyml/analyze/util.py @@ -132,7 +132,7 @@ def populate_onnx_model_info(onnx_model) -> Dict: ) except ValueError: # Models >2GB on disk cannot have their model size measured this - # way and will throw a ValueError https://github.com/onnx/turnkeyml/issues/318 + # way and will throw a ValueError https://github.com/onnx/turnkeyml/issues/41 pass return result_dict diff --git a/src/turnkeyml/cli/cli.py b/src/turnkeyml/cli/cli.py index 25db55e..c2656e3 100644 --- a/src/turnkeyml/cli/cli.py +++ b/src/turnkeyml/cli/cli.py @@ -432,9 +432,6 @@ def check_extension(choices, file_name): help="Commands for managing the models", ) - # Design note: the `models` command is simple right now, however some additional ideas - # are documented in https://github.com/onnx/turnkeyml/issues/247 - models_subparsers = models_parser.add_subparsers( title="models", help="Commands for managing the models", diff --git a/src/turnkeyml/common/labels.py b/src/turnkeyml/common/labels.py index a3f2807..812962e 100644 --- a/src/turnkeyml/common/labels.py +++ b/src/turnkeyml/common/labels.py @@ -14,9 +14,6 @@ def to_dict(label_list: List[str]) -> Dict[str, List[str]]: label_value = label_value.split(",") label_dict[label_key] = label_value except ValueError: - # FIXME: Create a proper warning for this once we have the right - # infrastructure for doing so. - # https://github.com/onnx/turnkeyml/issues/55 printing.log_warning( ( f"Malformed label {item} found. " diff --git a/test/cli.py b/test/cli.py index b38ceda..e6ce708 100644 --- a/test/cli.py +++ b/test/cli.py @@ -132,14 +132,10 @@ def assert_success_of_builds( check_perf: bool = False, check_opset: Optional[int] = None, check_iteration_count: Optional[int] = None, - runtime: str = "ort", check_onnx_file_count: Optional[int] = None, ) -> int: # Figure out the build name by surveying the build cache # for a build that includes test_script_name in the name - # TODO: simplify this code when - # https://github.com/onnx/turnkeyml/issues/16 - # is done builds = filesystem.get_all(cache_dir) builds_found = 0