From e77ac156cc03e163a23256ff870000fa94bce334 Mon Sep 17 00:00:00 2001 From: Daniel Holanda Date: Fri, 1 Dec 2023 11:17:52 -0800 Subject: [PATCH] Add slurm Ci test back (#46) --- .github/workflows/test_turnkey.yml | 26 ++++++++++++-------------- src/turnkeyml/cli/setup_venv.sh | 0 2 files changed, 12 insertions(+), 14 deletions(-) mode change 100644 => 100755 src/turnkeyml/cli/setup_venv.sh diff --git a/.github/workflows/test_turnkey.yml b/.github/workflows/test_turnkey.yml index 8549736..915bc47 100644 --- a/.github/workflows/test_turnkey.yml +++ b/.github/workflows/test_turnkey.yml @@ -106,21 +106,19 @@ jobs: sudo service slurmd start sudo service slurmctld start sudo service munge start - # TODO: Slurm test is commented out because it isn't working in OMZ CI - # @Daniel to fix and un-comment - # - name: Test turnkey on Slurm - # if: runner.os != 'Windows' - # shell: bash -el {0} - # run: | - # # Create conda environment for Slurm using srun (sbatch + wait) - # export SKIP_REQUIREMENTS_INSTALL="True" - # export TORCH_CPU="True" - # srun src/turnkeyml/cli/setup_venv.sh + - name: Test turnkey on Slurm + if: runner.os != 'Windows' + shell: bash -el {0} + run: | + # Create conda environment for Slurm using srun (sbatch + wait) + export SKIP_REQUIREMENTS_INSTALL="True" + export TORCH_CPU="True" + srun src/turnkeyml/cli/setup_venv.sh - # # Run tests on Slurm - # export TURNKEY_SLURM_USE_DEFAULT_MEMORY="True" - # turnkey benchmark models/selftest/linear.py --build-only --use-slurm --cache-dir local_cache - # bash test/helpers/check_slurm_output.sh slurm-2.out + # Run tests on Slurm + export TURNKEY_SLURM_USE_DEFAULT_MEMORY="True" + turnkey benchmark models/selftest/linear.py --build-only --use-slurm --cache-dir local_cache + bash test/helpers/check_slurm_output.sh slurm-2.out # Below tests are commented out as the GitHub runner runs out of space installing the requirements # - name: Check installation of requirements.txt and their compatibility with turnkey diff --git a/src/turnkeyml/cli/setup_venv.sh b/src/turnkeyml/cli/setup_venv.sh old mode 100644 new mode 100755