Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification PullPoint subscription and renewal #506

Open
jflevesque-genetec opened this issue Jan 6, 2025 · 4 comments
Open

Clarification PullPoint subscription and renewal #506

jflevesque-genetec opened this issue Jan 6, 2025 · 4 comments
Labels
24.12 documentation Improvements or additions to documentation Event

Comments

@jflevesque-genetec
Copy link
Contributor

Hi everyone,

I feel like we have removed Base Notification eventing from the specification a while ago because it has always been optional on clients to support it and only in Profile S. Since then, the default has always been PullPoint.

We've recently hit an issue with a device where the Subscription termination time is not updated by the PullMessages request and the answer we received was that we had to call the Renew command on the subscription. Looking at the WSDL, the Renew command is not listed and in the Core Spec, section 9.1, there's some mention of Renew for Base Notification, and also one mention in section 9.1, 3rd step saying Additionally it provides the Renew and Unsubscribe operations of the Base Subscription Manager Interface.
But then the Diagram does not show the Renew operation in the lifecycle of the subscription.

9.1.1 says: By default the pull point keep alive is controlled via the PullMessages operation. In this case, after a PullMessages response is returned, the subscription should be active for at least the timeout specified in the PullMessages request.
So if I understand this right, if I create a Subscription with an initial termination time of 2 minutes, then the moment I start calling PullMessages, the TerminationTime of the subscription becomes TimeOfLastPullMessagesResponse+PullMessageTimeoutValue OR TimeOfLastPullMessages+2*PullMessageTimeoutValue. The moment a new PullMessages request comes in, this subscription termination time is automatically updated.

Do I follow the spec properly or am I missing something?

@jflevesque-genetec jflevesque-genetec added documentation Improvements or additions to documentation Event 24.12 labels Jan 6, 2025
@bsriramprasad
Copy link
Contributor

bsriramprasad commented Jan 9, 2025

There is an existing DTT test "5.3.2 REALTIME PULLPOINT SUBSCRIPTION - RENEW" that is sending Renew command and expecting Renew response for a pull point subscription, If PullMessages is the ONLY mechanism to be used to renew the subscription and not via the Renew command this test needs to be removed, need to clone a ticket into DTT accordingly to do tool update and validate no regression in the existing profile tests.

@jflevesque-genetec
Copy link
Contributor Author

Opened #515 to remove the mention of the Renew command.
@bsriramprasad should I open an issue in the dtt workspace to fix the Renew usage?

@bsriramprasad
Copy link
Contributor

Opened #515 to remove the mention of the Renew command. @bsriramprasad should I open an issue in the dtt workspace to fix the Renew usage?

Yes, that would be good so that we don't miss to track the update.

@jflevesque-genetec
Copy link
Contributor Author

Created #303 for the DTT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.12 documentation Improvements or additions to documentation Event
Projects
None yet
Development

No branches or pull requests

2 participants