Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DimensionalData compat 0.27 #881

Open
arlowhite opened this issue Oct 14, 2024 · 0 comments
Open

DimensionalData compat 0.27 #881

arlowhite opened this issue Oct 14, 2024 · 0 comments
Labels
dependencies Upstream changes Flags issues that are likely to arise due to changes upstream

Comments

@arlowhite
Copy link
Collaborator

arlowhite commented Oct 14, 2024

DimensionalData compat is set to 0.27 (version 0.27.9)
https://github.com/rafaqz/DimensionalData.jl/releases

If we upgrade to 0.28.3 (current latest), we get this error when running tests:

 ERROR: LoadError: DimensionMismatch: Lookup values for DimensionalData.Dimensions.Dim{:species} of [1, 8, 15, 22, 29] and [2, 9, 16, 23, 30] do not match.
Stacktrace:
  [1] _failed_comparedims(t::DimensionalData.Dimensions.Throw{Nothing}, msg_intro::String)
    @ DimensionalData.Dimensions ~/.julia/packages/DimensionalData/igGyw/src/Dimensions/primitives.jl:569
...
    @ ADRIA.metrics ~/work/ADRIA.jl/ADRIA.jl/src/metrics/metrics.jl:204
 [16] (::ADRIA.metrics.Metric{typeof(ADRIA.metrics._relative_juveniles), Tuple{Symbol, Symbol, Symbol}, String, Bool})(raw::Array{Float64, 3}, args::DataFrames.DataFrame; kwargs::@Kwargs{})
    @ ADRIA.metrics ~/work/ADRIA.jl/ADRIA.jl/src/metrics/metrics.jl:46
 [17] (::ADRIA.metrics.Metric{typeof(ADRIA.metrics._relative_juveniles), Tuple{Symbol, Symbol, Symbol}, String, Bool})(raw::Array{Float64, 3}, args::DataFrames.DataFrame)
    @ ADRIA.metrics ~/work/ADRIA.jl/ADRIA.jl/src/metrics/metrics.jl:43

#878
https://github.com/open-AIMS/ADRIA.jl/actions/runs/11247637592/job/31271460535#step:6:1130

Reproduce

Run ADRIA.jl tests

Next Steps

Is this a bug in DimensionalData or do we need to change something to work with the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Upstream changes Flags issues that are likely to arise due to changes upstream
Projects
None yet
Development

No branches or pull requests

1 participant