Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for Animated Button #34

Open
OleDakotaJoe opened this issue Mar 4, 2022 · 5 comments
Open

Write tests for Animated Button #34

OleDakotaJoe opened this issue Mar 4, 2022 · 5 comments

Comments

@OleDakotaJoe
Copy link
Member

No description provided.

@OleDakotaJoe
Copy link
Member Author

As a developer, it would be helpful to know that we have not broken any existing features. In order to do this, we want to have as much reasonable test coverage as possible.

Acceptance Criteria:

  • Unit tests written for AnimatedButton Component
  • Tests pass

@arye-eidelman
Copy link
Contributor

Currently, the animated button doesn't work with the solid variant. we should probably test for that as well

@OleDakotaJoe
Copy link
Member Author

I believe the button is animated properly, the animation is just underwhelming (just applies a box shadow)
That was part of a POC and needs to be updated and added to

@arye-eidelman
Copy link
Contributor

arye-eidelman commented Mar 14, 2022

That's the plain button that gets the shadow. The animated button adds a background color (with an animation) on Hover. With the solid variant the background already has that color so nothing changes visually.

@arye-eidelman
Copy link
Contributor

After you start your storybook server you can see it at http://localhost:6006/?path=/story/components-buttons--animated-button&args=buttonVariant:0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants