-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "" for local includes #52
Comments
Thanks @phoppermann , would you like to submit a small pull request for this? |
Is there any particular reasoning for/against changing it? I believe the current method, does require you to explicitly add |
@rodneyp290 yes, it works normally. However, the include syntax with @leif81 are the files generated by xmlpg or was xmlpg only used for the initial version? |
I think the use of <> is the right one. Open DIS is a library that will get installed on the system e.g. /usr/local/include/dis6/Acknowledge.h. Then in your app you would do #include <dis6/Acknowledge.h> and it just works because that's a standard system search path no? |
In the early days the source files here were repeatedly generated by xmlpg and blindly overwritten everything here, but that no longer is the case. Corrections and improvements are being made directly to the source here now. |
Yes. However, that's not the point of the discussion. It's about the includes inside Open DIS. |
e.g. in
open-dis-cpp/src/dis6/AcknowledgePdu.cpp
Line 1 in a9f9f26
#include <dis6/AcknowledgePdu.h>
to#include "AcknowledgePdu.h"
The text was updated successfully, but these errors were encountered: