Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added marshalledSize to all classes #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VovaDev
Copy link

@VovaDev VovaDev commented Apr 3, 2024

Fixes #11.
Implemented marshalledSize for all classes (like in Java and C# implementations).
You still need to manually fill pdu.length field (aka pdu.length = pdu.marshalledSize()), but at least you could do it effortlessly.
Also includes some other critical fixes (typos in FirePdu, DirectedEnergyFirePdu and ReceiverPdu variable names).

vovadev added 2 commits April 4, 2024 02:00
…pdu.length field before serializing it). Also fixed critical typos in FirePdu, DirectedEnergyFirePdu and ReceiverPdu: transmitterEntityId
@leif81
Copy link
Member

leif81 commented May 10, 2024

@VovaDev thank-you for the proposed change.

A large change was merged today which has created a conflict in this PR. If you are still interested in proposing this change could you rebase your PR on the latest code in master to resolve the conflict.

@ngjunsiang
Copy link
Contributor

I like this suggestion, and have an idea to make this easier so that the marshalled size does not need to be hardcoded. But I need to wrap up some other work on the refactoring first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When serializing, length field is always zero
3 participants