IFFPdu improvements

[mimmi-matalamaki-insta-fi]

IFFPdu needs modifications so that Layer 3 information can be added to it. Layer 3 contains Mode 5 information.

Current IFFPdu only supports information for Layer 1 and 2. Current IFFLayer2Pdu extends IFFPdu which does not support to adding layer 3 information into IFFPdu.

Solution idea:

We would like to modify IFFPdu so that a layer information can be added directly to it and the layers do not need to extend IFFPdu.

Basically we would create corresponding data classes for layers 1, 2 and 3. (IffPduLayer1Data, IffPduLayer2Data, IffPduLayer3Data) These data classes would extend AbstractIffPduLayerData. Data classes can then be added to IffPdu via addLayer method. Then later when someone wants to create layer 4 and 5 they can simply create IffPduLayerData classes and add them to IffPdu.

Files that need modifications:

• DistributedEmissionFamilyPdus.xml and JavaGenerator.java
  -- These for IffPdu, AbstractIffPduLayerData, IffPduLayer1Data, IffPduLayer2Data and IffPduLayer3Data
• PduFactory.class on openddis7-java project

Is this solution okay to implement or do you have any suggestions for us how to improve it?

[brutzman]

Since edu.nps.moves.dis7.utilities.Mode5StatusRecord is only used by IFFPduTest, we are refactoring and moving it to edu.nps.moves.dis7.test.IFFMode5StatusRecord

[mimmi-matalamaki-insta-fi]

Moving IFFMode5StatusRecord under the tests should be reconsidered because IFFMode5StatusRecord has been made to be used in Mode5TransponderBasicData class in variable mode5Status. That way mode5Status is more clear to create than just inserting integer. Mode5TransponderBasicData is initialized in DistributedEmissionsFamilyPdus.xml and Mode5TransponderBasicData is variable in IFFPduLayer3TransponderFormatData.

We put it in edu.nps.moves.dis7.utilities.Mode5StatusRecord because both pdus and tests use Mode5StatusRecord class.

[brutzman]

Looks like we will need to move things back to original directories/packages, but suggest we continue to call the class itself IffMode5StatusRecord for clarity.

[terry-norbraten]

Suggest we move IffMode5StatusRecord to src-generated as a special case, and have it reside/copied into the PDU package as it's not really a utility, but a bonefide resource for the IFFPdus