Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

[HIGH PRIORITY] Have a new builtin processor that works with regex #41

Open
Bernardstanislas opened this issue Nov 7, 2022 · 8 comments
Assignees
Labels
Context: intricated deep understanding of the codebase required Difficulty: intermediate require some notions, but can be learned while doing Duration: 2 days will take about 2 days Techno: cairo cairo Techno: rust rust Type: feature a new feature to implement

Comments

@Bernardstanislas
Copy link
Contributor

Bernardstanislas commented Nov 7, 2022

Context

The cairo-rs vm has a trait HintProcessor, that is currently only implemented by their BuiltinHintProcessor.

This processor let us add custom hints, matching the hint code with an hardcoded string.

Goal

We want to go further with these custom hints, and be able to have a hint processor that will match hints based on a regex.
This would let us provide arguments to the Rust hint function associated with a regex.

I did a PR for this in the vm repo, but it was suggested that this should live in our project directly.

You can find some documentation here to learn more about their hint processor concept: https://github.com/lambdaclass/cairo-rs/tree/main/docs/hint_processor

What we expect from you

  • have the RegexHintProcessor used in our repo to be able to add regex-based custom hints
  • have improved the code from the PR to compile the regex at "hint processor compile time"
@Bernardstanislas Bernardstanislas added Type: feature a new feature to implement Context: intricated deep understanding of the codebase required Difficulty: intermediate require some notions, but can be learned while doing Techno: cairo cairo Techno: rust rust Duration: 2 days will take about 2 days labels Nov 7, 2022
@tdelabro tdelabro changed the title Have a new builtin processor that works with regex [HIGH PRIORITY] Have a new builtin processor that works with regex Nov 8, 2022
@tdelabro tdelabro assigned tdelabro and onlydust-bot and unassigned tdelabro Nov 9, 2022
@oxlime
Copy link
Contributor

oxlime commented Nov 10, 2022

request to assign

@tdelabro tdelabro assigned oxlime and unassigned onlydust-bot Nov 10, 2022
@Eikix Eikix moved this to In Progress in Cairo foundry Nov 23, 2022
@Eikix
Copy link
Collaborator

Eikix commented Jan 9, 2023

Hi, are you still participating on this issue?

@oxlime
Copy link
Contributor

oxlime commented Jan 9, 2023

Yes sorry holidays. Will get it done next day or two.

@Eikix
Copy link
Collaborator

Eikix commented Jan 9, 2023

hey, no worries:)!

we're in a bit of a pickle right now, some of the contributors of cairo-foundry are currently at an off-site event in the French alps, and we're all "pair programming" together on some issues
We chose this issue to move forward and better understand the cairo runner. We'll use it to onboard people.

we will do this issue in the chalet, but if you have free time these days, i'd be glad to assign you to another issue!

@Eikix Eikix assigned tdelabro and Eikix and unassigned oxlime Jan 9, 2023
@Eikix
Copy link
Collaborator

Eikix commented Jan 9, 2023

let me know if you have free time and want to work on a specific issue:)

@tdelabro
Copy link
Collaborator

@bacharif is working on this one

@tdelabro
Copy link
Collaborator

Good to know, @Bernardstanislas already did a version of this one for the cairo-rs repo, it had been refused as they prefer not to include it to their codebase for now.
Take inspiration from it:
lambdaclass/cairo-vm#524

@bacharif
Copy link
Contributor

For me

@tdelabro tdelabro assigned bacharif and unassigned tdelabro and Eikix Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Context: intricated deep understanding of the codebase required Difficulty: intermediate require some notions, but can be learned while doing Duration: 2 days will take about 2 days Techno: cairo cairo Techno: rust rust Type: feature a new feature to implement
Projects
None yet
Development

No branches or pull requests

6 participants