Prevent crashes if no board is detected #9
Conversation
- This presents a blank canvas and an editor that only states "No boards detected" if the user presses "No" with no boards connected
|
Josh implemented a simulation mode for the acquisition board plugin, which can be used for testing. Here's the code for it: https://github.com/open-ephys-plugins/acquisition-board/tree/main/Source/devices/simulated. Similar to the Neuropixels plugin, this plugin should prompt the user to run in simulation mode if no boards are detected. If the user selects “ yes,” the plugin should run in simulation mode. If the user selects “ no,” the plugin should create a blank editor and canvas. |
|
@anjaldoshi I believe that this PR accomplishes what you are saying. The simulated device works correctly, but issue #2 occurs when the user presses "No", which would immediately crash the GUI. Now, with this PR, it simply shows the blank editor and canvas (the editor is not totally blank, similar to the Neuropixels-PXI plugin it states "No boards detected"). Unlike the PXI plugin, the canvas here still opens, even thought it is totally blank. If that is acceptable behavior then I think this PR is ready for review. Let me know if there is anything I missed! |
|
Great! Thanks for confirming! I haven't tested it on my end yet, will do and let you know. |
This PR is slightly modeled after how the Neuropixels-PXI plugin handles the user pressing No if no hardware is connected. Namely, it skips the initialization steps that were previously crashing, and instead presents a mostly blank editor and a blank canvas that cannot perform any actions.
I could not figure out how to prevent the canvas from being automatically opened, so if anyone has any recommendations on how to do that it would be greatly appreciated!