Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback Signicat/kpn on generated eHerkenning metadata.xml #4785

Open
4 tasks
LaurensBurger opened this issue Oct 23, 2024 · 5 comments
Open
4 tasks

feedback Signicat/kpn on generated eHerkenning metadata.xml #4785

LaurensBurger opened this issue Oct 23, 2024 · 5 comments

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Oct 23, 2024

Thema / Theme

Admin

Omschrijving / Description

kpn:

  • Provide fields to add a "Administrative ContactPerson" to the metadata
  • Provide a unique field for eIDAS service description
  • Remove use="signing" from KeyDescriptor since the certificate is used for both encryption and singing
  • Add scoping for eIDAS service, which would direct users to the correct eIDAS screen (see changes-to-idp-scoping-in-signicat-identity-broker #2387)

Signicat:

  • <esc:PurposeStatement xml:lang="nl">Open Formulieren</esc:PurposeStatement> weglaten want hoort bij optionele attributen
    image

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response

@LaurensBurger LaurensBurger added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Oct 23, 2024
@joeribekker
Copy link
Contributor

Ik begrijp niet waarom we optionele attributen moeten weglaten...

@joeribekker joeribekker changed the title feedback Signacat on generated eHerkenning metadata.xml feedback Signicat on generated eHerkenning metadata.xml Oct 28, 2024
@joeribekker
Copy link
Contributor

Optional attributes can stay because KPN might need them (just a guess - we added them sometime for a reason).

Can someone check where that attribute kvk does need to be?

@joeribekker joeribekker added owner: maykin and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Oct 28, 2024
@joeribekker joeribekker added this to the Release 3.0 milestone Oct 28, 2024
@LaurensBurger LaurensBurger changed the title feedback Signicat on generated eHerkenning metadata.xml feedback Signicat/kpn on generated eHerkenning metadata.xml Nov 11, 2024
@LaurensBurger
Copy link
Collaborator Author

feedback from KPN regarding KVKnr
<md:RequestedAttribute Name="urn:etoegang:1.9:EntityConcernedID:KvKnr" isRequired="true"/> deze regel Verwijderen, het betreft hier een zogenaamd ‘identificerend kenmerk’ dat via het onboardingsformulier wordt opgenomen in de Diensten Catalogus van het stelsel.

they suggest the following which can be done form the admin already:

            <md:RequestedAttribute Name="urn:etoegang:1.9:attribute:FirstName" isRequired="true" />
            <md:RequestedAttribute Name="urn:etoegang:1.9:attribute:FamilyNameInfix"
                isRequired="true" />
            <md:RequestedAttribute Name="urn:etoegang:1.9:attribute:FamilyName" isRequired="true" />
            <md:RequestedAttribute Name="urn:etoegang:1.9:attribute:DateOfBirth" isRequired="true" />

@sergei-maertens
Copy link
Member

but, we don't use these attributes from the digid/eherkenning login, all we need is BSN/KVKNr and then we look up these details via prefill plugins.

@LaurensBurger
Copy link
Collaborator Author

Perhaps these suggestions were meant only for the eIDAS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants