Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using custom confirmation modals #4798

Open
robinmolen opened this issue Oct 28, 2024 · 0 comments · May be fixed by #4814
Open

Using custom confirmation modals #4798

robinmolen opened this issue Oct 28, 2024 · 0 comments · May be fixed by #4814
Assignees
@robinmolen
Labels
enhancement

Comments

@robinmolen
Copy link
Contributor

Thema / Theme

Frontend

Omschrijving / Description

Replacing the window.confirm(...) confirmations with a custom confirmation that uses our Modal component

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response
@robinmolen robinmolen self-assigned this Oct 28, 2024
robinmolen added a commit that referenced this issue Oct 28, 2024
@robinmolen
✨ [#4798] Added custom confirmation modal
78e46c3
robinmolen added a commit that referenced this issue Oct 28, 2024
@robinmolen
✨ [#4798] WIP Replacing window.confirm
16a0a22
@robinmolen robinmolen moved this from Todo to In Progress in Development Oct 29, 2024
robinmolen added a commit that referenced this issue Oct 29, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm
4de8d93
robinmolen added a commit that referenced this issue Oct 29, 2024
@robinmolen
📝 [#4798] Added todo
cdbefe2
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm
4866260
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm for the ZGW api group
be77221 
For this to work we need to use the React Select without Formik. The Formik React Select doesn't handle the custom onChange correctly, causing a setValue loop.
@robinmolen robinmolen linked a pull request Nov 8, 2024 that will close this issue
Feature/4798 custom confirmation modal #4814
Open
9 tasks
@robinmolen robinmolen linked a pull request Nov 8, 2024 that will close this issue
Open
9 tasks
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
🌐 [#4798] Translated confirmation buttons
75cff3b
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
✅ [#4798] Added story to showcase the custom confirmation modal
3e198d4
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
✨ [#4798] Added custom confirmation modal
34a61fc
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm
967f331
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm for the ZGW api group
b174845 
For this to work we need to use the React Select without Formik. The Formik React Select doesn't handle the custom onChange correctly, causing a setValue loop.
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
🌐 [#4798] Translated confirmation buttons
093d4e9
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
✅ [#4798] Added story to showcase the custom confirmation modal
4aaa7cc
robinmolen added a commit that referenced this issue Nov 8, 2024
@robinmolen
✅ [#4798] Added confirm modal handling to storybook tests
e5909be
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✅ [#4798] Added confirm modal handling to storybook tests
e1881c9
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✨ [#4798] Added custom confirmation modal
cd63a65
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm
3f91b74
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm for the ZGW api group
ea223a8 
For this to work we need to use the React Select without Formik. The Formik React Select doesn't handle the custom onChange correctly, causing a setValue loop.
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
🌐 [#4798] Translated confirmation buttons
734f725
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✅ [#4798] Added story to showcase the custom confirmation modal
95d30d0
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✅ [#4798] Added confirm modal handling to storybook tests
231063c
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm
8e6372d
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm for the ZGW api group
1a46753 
For this to work we need to use the React Select without Formik. The Formik React Select doesn't handle the custom onChange correctly, causing a setValue loop.
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
🌐 [#4798] Translated confirmation buttons
c5a77c7
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✅ [#4798] Added story to showcase the custom confirmation modal
58b38d1
robinmolen added a commit that referenced this issue Nov 11, 2024
@robinmolen
✅ [#4798] Added confirm modal handling to storybook tests
9dbb416
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
✅ [#4798] Fixing tests
9929b33 
Replaced window dialog handling with new dialog react modal handling
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
✨ [#4798] Added custom confirmation modal
09458ed
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm
7a89161
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
✨ [#4798] Replaced window.confirm with useConfirm for the ZGW api group
605f2d1 
For this to work we need to use the React Select without Formik. The Formik React Select doesn't handle the custom onChange correctly, causing a setValue loop.
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
🌐 [#4798] Translated confirmation buttons
1d5c200
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
✅ [#4798] Added story to showcase the custom confirmation modal
e19b84a
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
✅ [#4798] Added confirm modal handling to storybook tests
6004e0d
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
✅ [#4798] Fixing tests
7084e32 
Replaced window dialog handling with new dialog react modal handling
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
♿ [#4798] Using a real button for modal close
72aa129
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
💄 [#4798] Updated confirm modal styling
3712a44
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
♿ [#4798] Using a real button for modal close
e802a2e
robinmolen added a commit that referenced this issue Nov 12, 2024
@robinmolen
💄 [#4798] Updated confirm modal styling
c5b04b4
robinmolen added a commit that referenced this issue Nov 14, 2024
@robinmolen
♿ [#4798] Using a real button for modal close
d662732
robinmolen added a commit that referenced this issue Nov 14, 2024
@robinmolen
💄 [#4798] Updated confirm modal styling
3c47cb5
robinmolen added a commit that referenced this issue Nov 14, 2024
@robinmolen
✨ [#4798] Prevent useConfirm from rendering components
477649e 
Rendering a component inside a hook has some serious performance impacts. To prevent this, the useConfirm now returns the needed props and a reference to the confirmationModal component.

For more info: #4814 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
enhancement
Projects
Development
Status: Implemented
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/4798 custom confirmation modal open-formulieren/open-forms
1 participant
@robinmolen