Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "skipLibCheck" from formio-builder tsconfig #5017

Closed
robinmolen opened this issue Jan 14, 2025 · 1 comment
Closed

Remove "skipLibCheck" from formio-builder tsconfig #5017

robinmolen opened this issue Jan 14, 2025 · 1 comment
Labels
blocked enhancement triage Issue needs to be validated. Remove this label if the issue considered valid.

Comments

@robinmolen
Copy link
Contributor

Thema / Theme

Frontend

Omschrijving / Description

This issue describes a cleanup action for open-formulieren/formio-builder#198

The "skipLibCheck": true in the formio-builder tsconfig.json is a temporary solution for a react-leaflet-draw issue (see alex3165/react-leaflet-draw#188).

The index.d.ts file in the react-leaflet-draw package (so inside node_modules) tries to import and use a type definition, that is a namespace. This results into typescript error TS2709: Cannot use namespace XYZ as a type.

Seeing as this issue comes from a package inside node_modules, we cannot (easily) fix this ourselves. That is why we currently need "skipLibCheck": true.

Added value / Toegevoegde waarde

"skipLibCheck": true skips typescript checking of *.d.ts files, removing useful typescript information https://www.typescriptlang.org/tsconfig/#skipLibCheck.

Aanvullende opmerkingen / Additional context

We can only do this if the issue in react-leaflet-draw (alex3165/react-leaflet-draw#188) has been resolved

@robinmolen robinmolen added blocked triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Jan 14, 2025
@robinmolen
Copy link
Contributor Author

Update: react-leaflet-draw seems really quiet, a little too quiet...

I've solved this in the formio-builder using a localized patch file (using patch-package).
open-formulieren/formio-builder@d8aaa90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement triage Issue needs to be validated. Remove this label if the issue considered valid.
Projects
None yet
Development

No branches or pull requests

1 participant