tauri: migrating to V2 #585
Conversation
|
Both linux related tauri bugs have been closed. |
If the Linux version is to be released only as a Flatpak, this is not an issue as the webkit version is controlled in the Flatpak sandbox. This is done through the runtime sdk selection and not the system libraries. |
|
It was an issue because you couldn't develop or debug the app on ubuntu linux. |
Updated tauri packages Added tauri.linux.conf to disable tauri updater Also went with default flatpak install directory data/ folder for installation. Button on splash is replaced by Continue after locale select. Removed the Installation Directory setting for Linux build. I didn't think it should be able to be changed? If someone changed it to some directory in /home/ without giving access through flatseal/terminal it would throw errors so I assumed this was the best solution Added icons/desktop file since that should be upstream according to flathub maintainers. Once v2 is released I will update the flathub repo, since flathub bot builds from the git releases on this repo. The appdata file does not work as intended yet in the ci, have only gotten that to update properly on the flathub repo Ping me on Discord and I will create a request to add Vaser/tripp as maintainer, since I don't own the repo on flathub. --------- Co-authored-by: Milkfat32 <[email protected]>
| { | ||
| "plugins": { | ||
| "updater": { | ||
| "active": false | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
why we we disabling the updater in linux?
There was a problem hiding this comment.
Updates to flatpak is handled by the flatpak package manager. For diy distros like gentoo/arch this is done with flatpak update, for others this is usually in some software manager.
| "targets": [ | ||
| "msi", | ||
| "app", | ||
| "dmg" | ||
| ], |
There was a problem hiding this comment.
has no flatpak configuration, looks like we need to build the deb. CI will have to similarly be updated to accommodate the new release asset.
There was a problem hiding this comment.
That should not be necessary. Flatpaks in flathub are built in the flathub repository, so the launcher has its own repository in flathub. I have a workflow that creates the offline mirrors for the rust and npm dependencies and I build from source. I believe building a flatpak file outside the repository simply creates a .flatpakref file that users have to manually install. In the flathub repository it shows up in software managers.
There was a problem hiding this comment.
I don't really like the idea of us 100% depending on flathub / external repos to handle our linux distribution. From working on / observing PCSX2 they follow a model I much prefer, where they build the flatpak and publish it to flathub, that means the user can either download the flatpak directly from the pcsx2 website, or via flathub.
There was a problem hiding this comment.
Understandable. I did not know it was possible to build and publish outside the Flathub repositories. It does seem like a lot of extra work though, and I am not entirely sure how publishing to Flathub works. It seems like you need some kind of access token, which I don't know how to get other than perhaps asking for it? The documentation on this is very sparse.
I don't think it is that big a benefit to download the flatpak from the website, as users are generally conditioned to only seek software from repositories or through software managers
In my opinion this should be considered for the future, like it also seems the PCSX2 devs did as they moved from the flathub github repositories to self publishing, as to not stall the v2 branch for too long as I would have to do a lot more digging and asking around
Fixes #529 and #224
Fixes #581
May potentially solve #581 as it uses a newer version of webkit2gtk -- im currently convinced the UI rendering bug is the fault of webkitgtk2, and i tested last night that on newer versions (i used GNOME Web) it doesn't manifest.Before merging:
This is blocked for the following reasons: