Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/detect Launcher error [Linux] #630

Open
Zedb0T opened this issue Dec 9, 2024 · 3 comments
Open

Improve/detect Launcher error [Linux] #630

Zedb0T opened this issue Dec 9, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request linux

Comments

@Zedb0T
Copy link
Contributor

Zedb0T commented Dec 9, 2024

Reportedly installing the Launcher on the Steam Deck and selecting the Desktop as the install directory results in a
terminate called after throwing an instance of 'ghc::filesystem::filesystem_error' what(): No such file or directory And the support package fails to generate.

Maybe we can detect this and point the user to selecting a different directory such as Documents?

Also maybe its a good Idea to always generate the support package somewhere were we know it works, so we could investigate issues like this.

@Zedb0T Zedb0T added bug Something isn't working enhancement New feature or request linux labels Dec 9, 2024
@Zedb0T
Copy link
Contributor Author

Zedb0T commented Dec 9, 2024

Maybe something like

Generate support package at known good directory -> attempt to move it to where the install dir is/should be

Could be a more robust workflow? I do think we should try to get the support package into the install directory as I dont like the idea of leaving artifacts on the users disk, but in the case something goes critically wrong we still get a path they can check.

I guess when selecting a path we could try to write something to check if we can write in the dir then remove it, and if we cant then dont accept it as a valid selection too

@xTVaser
Copy link
Member

xTVaser commented Dec 9, 2024

The launcher as part of it's first-time setup will create a temporary file in the selected directory and reject it if it cannot. This should already be covered, but yes, proper investigation should happen and the problem should be reproduced.

This is unlikely to be a "linux" problem, the issue was reported for someone using the flatpak, which we have not officially migrated to.

@Milkfat32
Copy link
Contributor

Given the launcher will be distributed using flatpak from V2 I would suggest that the ability to select install directory is disabled via patch in the flatpak manifest. This is trivial.

The other issue would be generating the support package. I know that the flathub maintainers are not happy with giving a flatpak access to the /home directory by default, without a very good reason.

This could also be patched out and simply set to the runtime directory. For flatpaks those are in the .var/app/name-of-flatpak/ folder. But being hidden by default it might be annoying for users to navigate to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request linux
Projects
None yet
Development

No branches or pull requests

3 participants