Exception - imagesx(): Argument #1 ($image) must be of type GdImage, bool given

[dustinbrisebois]

MDL 4.1 getting this error:

line 386 of /mod/mediagallery/classes/item.php: TypeError thrown
line 386 of /mod/mediagallery/classes/item.php: call to imagesx()
line 296 of /mod/mediagallery/classes/item.php: call to mod_mediagallery\item->get_image_resized()
line 495 of /mod/mediagallery/classes/item.php: call to mod_mediagallery\item->generate_image_by_type()
line 622 of /mod/mediagallery/classes/item.php: call to mod_mediagallery\item->get_stored_file_by_type()
line 340 of /mod/mediagallery/classes/gallery.php: call to mod_mediagallery\item->get_image_url()
line 204 of /mod/mediagallery/renderer.php: call to mod_mediagallery\gallery->get_thumbnail()
line 173 of /mod/mediagallery/renderer.php: call to mod_mediagallery_renderer->gallery_list_item()
line 128 of /mod/mediagallery/classes/viewcontroller.php: call to mod_mediagallery_renderer->render_collection()
line 64 of /mod/mediagallery/classes/viewcontroller.php: call to mod_mediagallery\viewcontroller->action_viewcollection()
line 144 of /mod/mediagallery/view.php: call to mod_mediagallery\viewcontroller->display_action()

[dustinbrisebois]

I believe this issue has to do with this:

https://github.com/open-lms-open-source/moodle-mod_mediagallery/blob/876b1892fc27fa3098cd02c385998f2bc5bc7a86/classes/item.php#L333C70-L333C70

https://www.php.net/manual/en/function.imagecreatefromstring.php

Returns a GDImage OR False - however if the encoding and/or image are not processable it errors out.

[dustinbrisebois]

The problem is there is no sanity check if the file_get_contents is empty. In the event that an image isn't available (for whatever reason) the system automatically fails to check if the contents are good to process, and if the image is even of the right type.

[dustinbrisebois]

This

        $content = file_get_contents($tempfile);
        if (strlen($contents) == 0) {
            return False;
        }

is a very ugly fix but it does solve the issue