Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor --with-prrte configure option #12684

Open
hppritcha opened this issue Jul 16, 2024 · 0 comments
Open

refactor --with-prrte configure option #12684

hppritcha opened this issue Jul 16, 2024 · 0 comments
Labels
capstone24 issues to be dealt with by capstone24 students Severity: blocker Target: main Target: v6.0.x

Comments

@hppritcha
Copy link
Member

hppritcha commented Jul 16, 2024

As part of the Open MPI fork of PRRTe migration into the Open MPI source tree proper, the configury code supporting the --with-prrte configure option needs to be refactored. Currently this option allows for building Open MPI against an external install of the upstream PRRTe. As part of this process we no longer want to support this.
We do still want to support disabling the build of the embedded prrte code - currently in 3rd-party/pprte.

Also, the configure option should be renamed to something more obvious to a packagers/installer. The suggestion would be to rename the option to --with-rte. The default would be yes, in which case the embedded prrte code would be built. The --with-rte=no should also be supported. But any other option to --with-rte should result in an erroring out at the configure stage.

The code that needs to refactored is in the <path-to-ompi-workarea>/config/ompi_setup_prrte.m4.

Changing the configure option from --with--prrte to --with-rte will be somewhat complicated and may be made easier by moving the location of the PRRTE git submodule to 3rd-party/rte.

Staging changes in as one PR solely to reject a ---with-prrte=<path_to_an_external_prrte> would be pretty straightforward. Changing the configure argument to --with-rte can be done in a subsequent PR.

Solving this issue will give one experience with coding m4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capstone24 issues to be dealt with by capstone24 students Severity: blocker Target: main Target: v6.0.x
Projects
Development

No branches or pull requests

2 participants