From ff740b4256304b5ff7f6daacae349f3a88b51ce8 Mon Sep 17 00:00:00 2001 From: Edgar Gabriel Date: Fri, 6 Sep 2024 17:02:45 -0500 Subject: [PATCH] fcoll/vulcan: fix memory leak we didn't correctly free the fh->f_aggr_list array in the vulcan file_write_all file. Thanks @andymwood for reporting the issue and @ggouaillardet for identifying the cause for the leak. Fixes Issue #12677 (at least partially) Signed-off-by: Edgar Gabriel (cherry picked from commit 3fde6af4ac598a95db5b05c21b689e12fb507790) --- ompi/mca/fcoll/vulcan/fcoll_vulcan_file_write_all.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ompi/mca/fcoll/vulcan/fcoll_vulcan_file_write_all.c b/ompi/mca/fcoll/vulcan/fcoll_vulcan_file_write_all.c index c6fe8549fb0..5e03dd3ac29 100644 --- a/ompi/mca/fcoll/vulcan/fcoll_vulcan_file_write_all.c +++ b/ompi/mca/fcoll/vulcan/fcoll_vulcan_file_write_all.c @@ -728,8 +728,10 @@ exit : } free(broken_iov_arrays); free(fh->f_procs_in_group); + free(fh->f_aggr_list); fh->f_procs_in_group=NULL; fh->f_procs_per_group=0; + fh->f_aggr_list=NULL; free(result_counts); free(reqs);